[MIRROR] Emagged PDAs won't log to wirecarp. #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Emagged PDAs won't log to wirecarp. (#79707) ## About The Pull Request Currently, every time you open/close a program, that activity is logged for the RD to see. This includes Nukies opening their disk tracking app. Now, emagged PDAs will no longer log activities to Wirecarp, but I did replace it with a log when the PDA is first emagged. Basically, nukies are undetected, but Traitors can still be figured out. ## Why It's Good For The Game Closes tgstation/tgstation#77201 I thought this would be better as it makes more sense to stop logging when you're emagged, but as you are being emagged it will report the modification instead. ## Changelog :cl: fix: PDAs now log that they've been emagged, but will no longer log any further programs they open beyond that. This means Nukies don't sell themselves out by opening their disk tracking app. /:cl: * Emagged PDAs won't log to wirecarp. --------- Co-authored-by: John Willard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Skyrat: Skyrat-SS13/Skyrat-tg#25004
Original PR: tgstation/tgstation#79707
About The Pull Request
Currently, every time you open/close a program, that activity is logged for the RD to see. This includes Nukies opening their disk tracking app.
Now, emagged PDAs will no longer log activities to Wirecarp, but I did replace it with a log when the PDA is first emagged.
Basically, nukies are undetected, but Traitors can still be figured out.
Why It's Good For The Game
Closes tgstation/tgstation#77201
I thought this would be better as it makes more sense to stop logging when you're emagged, but as you are being emagged it will report the modification instead.
Changelog
🆑 JohnFulpWillard
fix: PDAs now log that they've been emagged, but will no longer log any further programs they open beyond that. This means Nukies don't sell themselves out by opening their disk tracking app.
/:cl: